#[cfg(not(feature = "std"))]
use crate::compat::{Box, Vec};

use core::any::Any;
use core::cell::RefCell;
use core::sync::atomic::Ordering;
#[cfg(feature = "std")]
use core::sync::atomic::AtomicBool;
use crate::compat::{Arc, HashMap, VecDeque};
#[cfg(feature = "std")]
use std::thread;
#[cfg(feature = "std")]
use crate::Instant;

use crate::actor::{ActorAddress, AnyActor, ContextInner, Ctx, Environment, ExitValue, ResumeSignal, SpawnRequest, StopReason, StopSignal, StopWithSignal, SystemInfo};
use crate::channel::Receiver;
use crate::config::MailboxOverflow;
use crate::delivery::{AddrMap, Envelope, TickContext, WorkerId};
use swactor_core::{ActorPhase, LifecycleEvent, lifecycle_transition};
use crate::stats::{ActorSnapshot, TickTiming, WorkerStats};
use crate::Error;

use crate::extension::WorkerExtension;

/// Route a message: try local pool first, then address_map for cross-worker,
/// then inbox_registry for external receivers.
fn route_to_pool_or_remote(
    pool: &mut ActorPool,
    tc: &TickContext,
    dest: ActorAddress,
    msg: Box<dyn Any + Send>,
) {
    if pool.contains(&dest) {
        pool.deliver(&dest, msg);
    } else {
        match tc.address_map.lookup(&dest) {
            Some(wid) => {
                tc.transfer_txs[wid.as_usize()].send(Envelope::new(dest, msg));
                #[cfg(feature = "std")]
                crate::runtime::notify_worker(tc.worker_threads, wid.as_usize());
            }
            None => {
                let _ = tc.inbox_registry.try_deliver(dest, msg);
            }
        }
    }
}

// ─── Worker ─────────────────────────────────────────────────────────────────

/// A worker owns a set of actors and runs them in a loop.
pub(crate) struct Worker {
    pub(crate) id: WorkerId,
    pub(crate) pool: ActorPool,
    transfer_rx: Receiver<Envelope>,
    spawn_rx: Receiver<SpawnRequest>,
    stats: Arc<WorkerStats>,
    /// Reusable scratch buffer for building per-actor snapshots.
    snapshot_buf: Vec<ActorSnapshot>,
    /// Per-worker extension (e.g., timer wheel). Created by RuntimeExtension factory.
    pub(crate) worker_ext: Option<Box<dyn WorkerExtension>>,
    /// True if the previous tick did work — ensures one full tick follows a productive
    /// tick so pending_local messages delivered to mailboxes get drained.
    has_backlog: bool,
}

impl Worker {
    pub(crate) fn new(
        id: WorkerId,
        transfer_rx: Receiver<Envelope>,
        spawn_rx: Receiver<SpawnRequest>,
        stats: Arc<WorkerStats>,
        default_mailbox_capacity: usize,
        default_overflow_policy: MailboxOverflow,
    ) -> Self {
        Self {
            id,
            pool: ActorPool::new(default_mailbox_capacity, default_overflow_policy),
            transfer_rx,
            spawn_rx,
            stats,
            snapshot_buf: Vec::new(),
            worker_ext: None,
            has_backlog: false,
        }
    }

    /// Run one iteration of the worker loop. Returns `true` if any work was done.
    /// Drain the spawn queue, inserting new actors into the pool.
    /// Used in phases 1 and 4 of tick_once.
    fn drain_spawns(&mut self, tc: &TickContext) -> bool {
        let mut did_work = false;
        #[cfg(feature = "tracing")]
        let mut spawn_count: usize = 0;
        while let Some(mut req) = self.spawn_rx.try_recv() {
            if let Some(ext) = tc.extension {
                #[cfg(feature = "std")]
                let uptime_ms = tc.created_at.elapsed().as_millis() as u64;
                #[cfg(not(feature = "std"))]
                let uptime_ms = 0u64;
                req.env = ext.on_spawn(req.addr, req.parent, req.env, uptime_ms);
            }
            self.pool.insert(req);
            #[cfg(feature = "tracing")]
            { spawn_count += 1; }
            did_work = true;
        }
        #[cfg(feature = "tracing")]
        if spawn_count > 0 {
            tracing::debug!(worker_id = self.id.0, count = spawn_count, "worker.spawns_drained");
        }
        did_work
    }

    /// Phase 7: clean up dead actors, deliver death notifications, GC extension state.
    fn cleanup_dead_actors(&mut self, tc: &TickContext) -> bool {
        let cleanup_pending: RefCell<Vec<(ActorAddress, Box<dyn Any + Send>)>> =
            RefCell::new(Vec::new());
        let cleanup_stops: RefCell<Vec<ActorAddress>> = RefCell::new(Vec::new());
        let cleanup_stop_withs: RefCell<Vec<(ActorAddress, ExitValue)>> = RefCell::new(Vec::new());
        let cleanup_suspends: RefCell<Vec<ActorAddress>> = RefCell::new(Vec::new());
        let cleanup_requests: RefCell<Vec<Box<dyn Any + Send>>> = RefCell::new(Vec::new());
        let dead = {
            let cleanup_ctx = WorkerContext {
                worker_id: self.id,
                tc,
                pending_local: &cleanup_pending,
                stop_requests: &cleanup_stops,
                stop_with_values: &cleanup_stop_withs,
                suspend_requests: &cleanup_suspends,
                worker_requests: &cleanup_requests,
                stats: &self.stats,
            };
            self.pool.cleanup_dead(&cleanup_ctx)
        };

        let had_dead = !dead.is_empty();
        if had_dead {
            for (addr, _, _) in &dead {
                tc.address_map.remove(addr);
            }

            if let Some(ext) = tc.extension {
                let notifications = ext.on_actor_death(&dead);
                let dead_addrs: Vec<_> = dead.iter().map(|(a, _, _)| *a).collect();
                ext.cleanup_dead(&dead_addrs);
                for (dest, msg) in notifications {
                    route_to_pool_or_remote(&mut self.pool, tc, dest, msg);
                }
            }

            self.stats.num_actors.store(self.pool.len(), Ordering::Relaxed);
        }

        // Deliver any messages sent during on_stop callbacks
        for (addr, msg) in cleanup_pending.into_inner() {
            self.pool.deliver(&addr, msg);
        }

        // GC per-worker extension state for dead actors
        if let Some(ext) = &mut self.worker_ext {
            let dead_addrs: Vec<ActorAddress> = dead.iter().map(|(a, _, _)| *a).collect();
            ext.gc_dead(&dead_addrs);
        }

        had_dead
    }

    pub(crate) fn tick_once(&mut self, tc: &TickContext) -> bool {
        #[cfg(feature = "tracing")]
        let _span = tracing::trace_span!("worker.tick", worker_id = self.id.0).entered();

        // Fast idle path: skip the entire tick when nothing could have changed.
        // Cost: ~3 atomic loads, zero syscalls, zero actor iteration.
        if !self.has_backlog
            && self.spawn_rx.is_empty()
            && self.transfer_rx.is_empty()
            && !self.worker_ext.as_ref().map_or(false, |e| e.has_pending_work())
        {
            return false;
        }

        let mut did_work = false;
        #[cfg(feature = "std")]
        let t0 = Instant::now();

        // 1. Drain spawn queue → add actors to pool
        did_work |= self.drain_spawns(tc);
        #[cfg(feature = "std")]
        let t1 = Instant::now();

        // 2. Drain transfer queue → deliver envelopes to actors
        while let Some(envelope) = self.transfer_rx.try_recv() {
            let dest = envelope.dest();
            let payload = envelope.into_payload();
            self.pool.deliver(&dest, payload);
            did_work = true;
        }
        #[cfg(feature = "std")]
        let t2 = Instant::now();

        // 2.5. Fire per-worker extension (e.g., timers) → deliver before tick_all
        let ext_msgs: Vec<_> = self.worker_ext.as_mut()
            .map(|ext| ext.on_tick())
            .unwrap_or_default();
        for (dest, msg) in ext_msgs {
            route_to_pool_or_remote(&mut self.pool, tc, dest, msg);
            did_work = true;
        }

        // 3. Tick all actors with WorkerContext
        let pending_local: RefCell<Vec<(ActorAddress, Box<dyn Any + Send>)>> =
            RefCell::new(Vec::new());
        let stop_requests: RefCell<Vec<ActorAddress>> = RefCell::new(Vec::new());
        let stop_with_values: RefCell<Vec<(ActorAddress, ExitValue)>> = RefCell::new(Vec::new());
        let suspend_requests: RefCell<Vec<ActorAddress>> = RefCell::new(Vec::new());
        let worker_requests: RefCell<Vec<Box<dyn Any + Send>>> = RefCell::new(Vec::new());

        let processed;
        {
            let worker_ctx = WorkerContext {
                worker_id: self.id,
                tc,
                pending_local: &pending_local,
                stop_requests: &stop_requests,
                stop_with_values: &stop_with_values,
                suspend_requests: &suspend_requests,
                worker_requests: &worker_requests,
                stats: &self.stats,
            };
            processed = self.pool.tick_all(&worker_ctx, &self.stats, tc.config.actor_message_budget, &stop_requests, &stop_with_values, &suspend_requests);
            if processed > 0 {
                did_work = true;
            }
        }
        #[cfg(feature = "std")]
        let t3 = Instant::now();

        #[cfg(feature = "tracing")]
        if processed > 0 {
            tracing::debug!(
                worker_id = self.id.0,
                messages_processed = processed,
                "worker.tick_all"
            );
        }

        // 4. Drain spawn queue again — actors spawned during step 3
        //    must be in the pool before pending_local delivery.
        did_work |= self.drain_spawns(tc);
        #[cfg(feature = "std")]
        let t4 = Instant::now();

        // 5. Drain pending_local buffer → deliver to local actors
        let pending = pending_local.into_inner();
        if !pending.is_empty() {
            did_work = true;
        }
        for (addr, msg) in pending {
            self.pool.deliver(&addr, msg);
        }

        // 5.5. Process worker extension requests from handlers (e.g., timer scheduling)
        if let Some(ext) = &mut self.worker_ext {
            for request in worker_requests.into_inner() {
                ext.handle_request(request);
            }
        }

        #[cfg(feature = "std")]
        let t5 = Instant::now();

        // 6. Publish stats (skip entirely when idle to avoid allocation + mutex)
        let drops = self.pool.take_drops();
        if did_work {
            self.stats.num_actors.store(self.pool.len(), Ordering::Relaxed);
            self.stats.total_mailbox_depth.store(self.pool.total_mailbox_depth(), Ordering::Relaxed);
            self.stats.messages_processed.fetch_add(processed as u64, Ordering::Relaxed);
            if drops > 0 {
                self.stats.messages_dropped.fetch_add(drops as u64, Ordering::Relaxed);
            }

            if let Some(hook) = tc.stats_hook {
                self.pool.mailbox_depths_into(&mut self.snapshot_buf);
                hook.on_tick(self.id.0, &self.snapshot_buf);
            }
        }

        #[cfg(feature = "std")]
        let t6 = Instant::now();

        // Record tick timing
        let timing = TickTiming {
            #[cfg(feature = "std")]
            phase_us: [
                t1.duration_since(t0).as_micros() as u64,
                t2.duration_since(t1).as_micros() as u64,
                t3.duration_since(t2).as_micros() as u64,
                t4.duration_since(t3).as_micros() as u64,
                t5.duration_since(t4).as_micros() as u64,
                t6.duration_since(t5).as_micros() as u64,
            ],
            #[cfg(not(feature = "std"))]
            phase_us: [0; 6],
            messages_processed: processed,
            did_work,
        };
        self.stats.push_tick_timing(timing);

        #[cfg(feature = "tracing")]
        if did_work {
            tracing::debug!(
                worker_id = self.id.0,
                num_actors = self.pool.len(),
                mailbox_depth = self.pool.total_mailbox_depth(),
                messages_processed = processed,
                "worker.stats"
            );
        }

        // 7. Clean up poisoned and stopping actors
        did_work |= self.cleanup_dead_actors(tc);

        self.has_backlog = did_work;
        did_work
    }

    #[cfg(feature = "std")]
    pub(crate) fn run(&mut self, tc: &TickContext, is_running: &AtomicBool) {
        #[cfg(feature = "tracing")]
        let _span = tracing::info_span!("worker.run", worker_id = self.id.0).entered();

        while is_running.load(Ordering::Acquire) {
            if !self.tick_once(tc) {
                // Park indefinitely — woken by unpark() from send_to/spawn/stop/shutdown.
                // Spurious wakes hit the fast idle path (~3 atomic loads) and park again.
                thread::park();
            }
        }
    }
}

/// The `ContextInner` impl for worker threads.
///
/// Same-worker sends are buffered in `pending_local` (delivered after current tick round).
/// Cross-worker sends go through the transfer queue.
struct WorkerContext<'a> {
    worker_id: WorkerId,
    tc: &'a TickContext<'a>,
    pending_local: &'a RefCell<Vec<(ActorAddress, Box<dyn Any + Send>)>>,
    stop_requests: &'a RefCell<Vec<ActorAddress>>,
    stop_with_values: &'a RefCell<Vec<(ActorAddress, ExitValue)>>,
    suspend_requests: &'a RefCell<Vec<ActorAddress>>,
    worker_requests: &'a RefCell<Vec<Box<dyn Any + Send>>>,
    stats: &'a WorkerStats,
}

impl ContextInner for WorkerContext<'_> {
    fn send_any(&self, addr: ActorAddress, msg: Box<dyn Any + Send>) -> Result<(), Error> {
        match self.tc.address_map.lookup(&addr) {
            Some(wid) if wid == self.worker_id => {
                self.stats.local_sends.fetch_add(1, Ordering::Relaxed);
                self.pending_local.borrow_mut().push((addr, msg));
                Ok(())
            }
            Some(wid) => {
                self.stats.cross_sends.fetch_add(1, Ordering::Relaxed);
                self.tc.transfer_txs[wid.as_usize()].send(Envelope::new(addr, msg));
                #[cfg(feature = "std")]
                crate::runtime::notify_worker(self.tc.worker_threads, wid.as_usize());
                Ok(())
            }
            None => {
                self.stats.inbox_sends.fetch_add(1, Ordering::Relaxed);
                self.tc.route_nonlocal(addr, msg)
            }
        }
    }

    fn spawn_any(&self, request: SpawnRequest) {
        let worker_id = self.tc.placement.next_worker();
        self.tc.address_map.insert(request.addr, worker_id);
        self.tc.spawn_txs[worker_id.as_usize()]
            .send(request);
        #[cfg(feature = "std")]
        crate::runtime::notify_worker(self.tc.worker_threads, worker_id.as_usize());
    }

    fn request_stop(&self, addr: ActorAddress) {
        self.stop_requests.borrow_mut().push(addr);
    }

    fn request_stop_with(&self, addr: ActorAddress, value: ExitValue) {
        self.stop_with_values.borrow_mut().push((addr, value));
    }

    fn request_suspend(&self, addr: ActorAddress) {
        self.suspend_requests.borrow_mut().push(addr);
    }

    fn request_resume(&self, addr: ActorAddress) {
        // Same-worker: buffer as pending_local ResumeSignal
        // Cross-worker: would go through transfer queue (handled by Runtime impl)
        self.pending_local.borrow_mut().push((addr, Box::new(ResumeSignal)));
    }

    fn post_worker_request(&self, request: Box<dyn Any + Send>) {
        self.worker_requests.borrow_mut().push(request);
    }

    fn extension(&self) -> Option<&dyn crate::extension::RuntimeExtension> {
        self.tc.extension
    }

    fn system_info(&self) -> SystemInfo {
        let num_workers = self.tc.config.num_threads.max(1);
        let total_actors: usize = self.tc.worker_stats.iter()
            .map(|ws| ws.num_actors.load(Ordering::Relaxed))
            .sum();
        #[cfg(feature = "std")]
        let uptime_ms = self.tc.created_at.elapsed().as_millis() as u64;
        #[cfg(not(feature = "std"))]
        let uptime_ms = 0u64;
        SystemInfo {
            worker_id: self.worker_id.0,
            num_workers,
            total_actors,
            uptime_ms,
        }
    }
}

struct ActorSlot {
    mailbox: VecDeque<Box<dyn Any + Send>>,
    actor: Box<dyn AnyActor>,
    /// Lifecycle phase — replaces the old `started`, `poisoned`, `stopping`, `suspended` booleans.
    phase: ActorPhase,
    last_msg_type: Option<&'static str>,
    messages_processed: u64,
    /// Per-message-type counters (bounded to 32 entries).
    msg_type_counts: HashMap<&'static str, u64>,
    /// Per-actor mailbox capacity. 0 = unbounded.
    mailbox_capacity: usize,
    overflow_policy: MailboxOverflow,
    /// Address of the actor that spawned this one, or `None` for externally-spawned actors.
    parent_addr: Option<ActorAddress>,
    /// Inherited environment from parent (or empty for runtime-spawned actors).
    env: Environment,
    /// Typed exit value set by `ctx.stop_with()`.
    exit_value: Option<ExitValue>,
}

/// Per-worker actor storage. Owns per-actor mailboxes.
pub(crate) struct ActorPool {
    actors: AddrMap<ActorSlot>,
    default_mailbox_capacity: usize,
    default_overflow_policy: MailboxOverflow,
    /// Messages dropped this tick due to mailbox overflow. Reset after publishing to stats.
    drops_this_tick: usize,
}

impl ActorPool {
    pub fn new(default_mailbox_capacity: usize, default_overflow_policy: MailboxOverflow) -> Self {
        Self {
            #[cfg(feature = "std")]
            actors: std::collections::HashMap::with_hasher(crate::delivery::AddrBuildHasher),
            #[cfg(not(feature = "std"))]
            actors: AddrMap::new(),
            default_mailbox_capacity,
            default_overflow_policy,
            drops_this_tick: 0,
        }
    }

    pub fn insert(&mut self, req: SpawnRequest) {
        let cap = self.default_mailbox_capacity;
        let prealloc = if cap > 0 { cap.min(64) } else { 16 };
        self.actors.insert(req.addr, ActorSlot {
            mailbox: VecDeque::with_capacity(prealloc),
            actor: req.actor,
            phase: ActorPhase::Unstarted,
            last_msg_type: None,
            messages_processed: 0,
            msg_type_counts: HashMap::new(),
            mailbox_capacity: self.default_mailbox_capacity,
            overflow_policy: self.default_overflow_policy,
            parent_addr: req.parent,
            env: req.env,
            exit_value: None,
        });
    }

    /// Deliver a type-erased message to the actor at `addr`.
    /// Returns `true` if the actor exists (message handled or dropped; type check deferred to tick).
    pub fn deliver(&mut self, addr: &ActorAddress, msg: Box<dyn Any + Send>) -> bool {
        if let Some(slot) = self.actors.get_mut(addr) {
            // Intercept control signals for suspended actors: they skip tick_all
            // so we must handle resume/stop at delivery time.
            if slot.phase == ActorPhase::Suspended {
                if msg.is::<ResumeSignal>() {
                    slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::Resumed);
                    return true;
                }
                if msg.is::<StopSignal>() {
                    slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::StopRequested);
                    slot.mailbox.clear();
                    return true;
                }
                if msg.is::<StopWithSignal>() {
                    if let Ok(sig) = msg.downcast::<StopWithSignal>() {
                        slot.exit_value = Some(sig.0);
                    }
                    slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::StopWithRequested);
                    slot.mailbox.clear();
                    return true;
                }
            }
            match swactor_core::mailbox_accept(slot.mailbox.len(), slot.mailbox_capacity, slot.overflow_policy) {
                swactor_core::MailboxDecision::Accept => {}
                swactor_core::MailboxDecision::RejectNewest => {
                    self.drops_this_tick += 1;
                    return true;
                }
                swactor_core::MailboxDecision::EvictOldest => {
                    slot.mailbox.pop_front();
                    self.drops_this_tick += 1;
                }
            }
            slot.mailbox.push_back(msg);
            true
        } else {
            false
        }
    }

    /// Take and reset the drop counter for this tick.
    pub fn take_drops(&mut self) -> usize {
        core::mem::replace(&mut self.drops_this_tick, 0)
    }

    /// Tick all actors in the pool. Returns the number of messages processed.
    ///
    /// Each actor processes up to `budget` messages per tick (0 = unlimited).
    /// This prevents a single hot actor from starving others on the same worker.
    pub fn tick_all(
        &mut self,
        inner: &dyn ContextInner,
        stats: &WorkerStats,
        budget: usize,
        stop_requests: &RefCell<Vec<ActorAddress>>,
        stop_with_values: &RefCell<Vec<(ActorAddress, ExitValue)>>,
        suspend_requests: &RefCell<Vec<ActorAddress>>,
    ) -> usize {
        let mut count = 0;
        for (&addr, slot) in self.actors.iter_mut() {
            if !swactor_core::should_tick_actor(slot.phase) {
                // Discard mailbox for poisoned/stopping; suspended keeps queueing
                if slot.phase == ActorPhase::Poisoned || slot.phase == ActorPhase::Stopping {
                    slot.mailbox.clear();
                }
                continue;
            }

            #[cfg(feature = "tracing")]
            let _actor_span = tracing::trace_span!("actor.tick", actor_addr = %addr).entered();

            // Snapshot self-stats before creating Ctx
            let snap_processed = slot.messages_processed;
            let snap_depth = slot.mailbox.len();
            let mut snap_type_counts: Vec<(&'static str, u64)> =
                slot.msg_type_counts.iter().map(|(&k, &v)| (k, v)).collect();
            snap_type_counts.sort_by(|a, b| b.1.cmp(&a.1));

            let ctx = Ctx::new(inner, addr, slot.parent_addr, slot.env.clone(), snap_processed, snap_depth, snap_type_counts);

            // Call on_start once, before first message
            if slot.phase == ActorPhase::Unstarted {
                #[cfg(feature = "std")]
                let start_result = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
                    slot.actor.on_start(&ctx);
                }));
                #[cfg(not(feature = "std"))]
                let start_result: Result<(), ()> = { slot.actor.on_start(&ctx); Ok(()) };
                if start_result.is_err() {
                    stats.panics.fetch_add(1, Ordering::Relaxed);
                    #[cfg(feature = "std")]
                    eprintln!("swactor: actor {addr} panicked in on_start — poisoned");
                    #[cfg(feature = "tracing")]
                    tracing::error!(actor_addr = %addr, "actor.on_start_panicked");
                    slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::StartPanicked);
                    slot.mailbox.clear();
                    continue;
                }
                slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::Started);
                // Check if on_start requested stop or stop_with
                {
                    let stops = stop_requests.borrow();
                    if !stops.is_empty() && stops.contains(&addr) {
                        drop(stops);
                        slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::StopRequested);
                        stats.stops.fetch_add(1, Ordering::Relaxed);
                        slot.mailbox.clear();
                        // Check for stop_with value
                        let mut sws = stop_with_values.borrow_mut();
                        if let Some(pos) = sws.iter().position(|(a, _)| *a == addr) {
                            let (_, val) = sws.swap_remove(pos);
                            slot.exit_value = Some(val);
                        }
                        continue;
                    }
                }
                // Check if on_start requested stop_with (without plain stop)
                {
                    let mut sws = stop_with_values.borrow_mut();
                    if let Some(pos) = sws.iter().position(|(a, _)| *a == addr) {
                        let (_, val) = sws.swap_remove(pos);
                        slot.exit_value = Some(val);
                        slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::StopWithRequested);
                        stats.stops.fetch_add(1, Ordering::Relaxed);
                        slot.mailbox.clear();
                        continue;
                    }
                }
                // Check if on_start requested suspend
                {
                    let suspends = suspend_requests.borrow();
                    if !suspends.is_empty() && suspends.contains(&addr) {
                        drop(suspends);
                        slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::SuspendRequested);
                        continue;
                    }
                }
            }

            let mut actor_count = 0usize;
            while let Some(msg) = slot.mailbox.pop_front() {
                // Intercept StopSignal (from external runtime.stop_actor)
                if msg.is::<StopSignal>() {
                    slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::StopRequested);
                    stats.stops.fetch_add(1, Ordering::Relaxed);
                    slot.mailbox.clear();
                    #[cfg(feature = "tracing")]
                    tracing::info!(actor_addr = %addr, "actor.stop_requested");
                    break;
                }

                // Intercept StopWithSignal (from external runtime)
                if msg.is::<StopWithSignal>() {
                    if let Ok(sig) = msg.downcast::<StopWithSignal>() {
                        slot.exit_value = Some(sig.0);
                    }
                    slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::StopWithRequested);
                    stats.stops.fetch_add(1, Ordering::Relaxed);
                    slot.mailbox.clear();
                    break;
                }

                #[cfg(feature = "std")]
                let result = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
                    slot.actor.handle_any(&ctx, msg)
                }));
                #[cfg(not(feature = "std"))]
                let result: Result<Option<&'static str>, ()> = Ok(slot.actor.handle_any(&ctx, msg));
                match result {
                    Ok(None) => {
                        stats.type_mismatches.fetch_add(1, Ordering::Relaxed);
                    }
                    Err(_) => {
                        stats.panics.fetch_add(1, Ordering::Relaxed);
                        slot.mailbox.clear();
                        #[cfg(feature = "std")]
                        eprintln!("swactor: actor {addr} panicked — poisoned, future messages will be discarded");
                        #[cfg(feature = "tracing")]
                        tracing::error!(actor_addr = %addr, "actor.panicked");
                        slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::MessagePanicked);
                        slot.mailbox.clear();
                        break;
                    }
                    Ok(Some(type_name)) => {
                        slot.last_msg_type = Some(type_name);
                        slot.messages_processed += 1;
                        // Track per-type counts (bounded to 32 distinct types)
                        if slot.msg_type_counts.len() < 32 || slot.msg_type_counts.contains_key(type_name) {
                            *slot.msg_type_counts.entry(type_name).or_insert(0) += 1;
                        }
                    }
                }
                count += 1;
                actor_count += 1;

                // Check if handler requested self-stop or stop_with
                {
                    let stops = stop_requests.borrow();
                    let has_stop = !stops.is_empty() && stops.contains(&addr);
                    drop(stops);

                    let mut sws = stop_with_values.borrow_mut();
                    let sw_pos = sws.iter().position(|(a, _)| *a == addr);

                    if has_stop || sw_pos.is_some() {
                        if let Some(pos) = sw_pos {
                            let (_, val) = sws.swap_remove(pos);
                            slot.exit_value = Some(val);
                        }
                        drop(sws);
                        slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::StopRequested);
                        stats.stops.fetch_add(1, Ordering::Relaxed);
                        slot.mailbox.clear();
                        break;
                    }
                    drop(sws);
                }

                // Check if handler requested suspend
                {
                    let suspends = suspend_requests.borrow();
                    if !suspends.is_empty() && suspends.contains(&addr) {
                        drop(suspends);
                        slot.phase = lifecycle_transition(slot.phase, LifecycleEvent::SuspendRequested);
                        break; // stop processing this actor's messages this tick
                    }
                }

                if swactor_core::budget_exhausted(actor_count, budget) {
                    break;
                }
            }
        }
        count
    }

    pub fn len(&self) -> usize {
        self.actors.len()
    }

    pub fn contains(&self, addr: &ActorAddress) -> bool {
        self.actors.contains_key(addr)
    }

    pub fn total_mailbox_depth(&self) -> usize {
        self.actors.values().map(|slot| slot.mailbox.len()).sum()
    }

    /// Remove poisoned and stopping actors, returning their addresses, stop reasons,
    /// and optional exit values.
    /// Called after tick_all so the caller can clean up the address map.
    ///
    /// For stopping actors: calls `on_stop()` before removal (wrapped in catch_unwind).
    /// For poisoned actors: `on_stop()` is NOT called (state may be corrupt).
    pub fn cleanup_dead(&mut self, inner: &dyn ContextInner) -> Vec<(ActorAddress, StopReason, Option<ExitValue>)> {
        let dead_addrs: Vec<ActorAddress> = self
            .actors
            .iter()
            .filter(|(_, slot)| slot.phase == ActorPhase::Poisoned || slot.phase == ActorPhase::Stopping)
            .map(|(&addr, _)| addr)
            .collect();
        let mut dead = Vec::with_capacity(dead_addrs.len());
        for addr in dead_addrs {
            if let Some(mut slot) = self.actors.remove(&addr) {
                let reason = swactor_core::cleanup_stop_reason(slot.phase, slot.exit_value.is_some());
                // Call on_stop for gracefully stopping actors only
                if slot.phase == ActorPhase::Stopping {
                    let mut type_counts: Vec<(&'static str, u64)> =
                        slot.msg_type_counts.iter().map(|(&k, &v)| (k, v)).collect();
                    type_counts.sort_by(|a, b| b.1.cmp(&a.1));
                    let ctx = Ctx::new(
                        inner, addr, slot.parent_addr, slot.env.clone(),
                        slot.messages_processed,
                        slot.mailbox.len(),
                        type_counts,
                    );
                    #[cfg(feature = "std")]
                    { let _ = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
                        slot.actor.on_stop(&ctx);
                    })); }
                    #[cfg(not(feature = "std"))]
                    { slot.actor.on_stop(&ctx); }
                }
                dead.push((addr, reason, slot.exit_value.take()));
                // slot is dropped here — actor resources freed
            }
        }
        dead
    }

    /// Fill `out` with per-actor snapshots, reusing the existing allocation.
    pub fn mailbox_depths_into(&self, out: &mut Vec<ActorSnapshot>) {
        out.clear();
        out.extend(self.actors.iter().map(|(&addr, slot)| {
            let mut type_counts: Vec<(&'static str, u64)> =
                slot.msg_type_counts.iter().map(|(&k, &v)| (k, v)).collect();
            type_counts.sort_by(|a, b| b.1.cmp(&a.1));
            ActorSnapshot {
                address: addr,
                mailbox_depth: slot.mailbox.len(),
                last_msg_type: slot.last_msg_type,
                messages_processed: slot.messages_processed,
                poisoned: slot.phase == ActorPhase::Poisoned,
                message_type_counts: type_counts,
            }
        }));
    }
}